(PC-21416) feat(statusBar): blur/white status bar home and profile #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S4andro
force-pushed
the
PC-21416-blur-status-bar-home-and-profile
branch
2 times, most recently
from
c8719ea to
b39bcf9
Compare
S4andro
commented
Jul 28, 2023
| <Section title={isLoggedIn ? 'Paramètres du compte' : 'Paramètres de l’application'}> | ||
| <VerticalUl> | ||
| {!!isLoggedIn && ( | ||
| <View> |
There was a problem hiding this comment.
dans ce fichier j'ai juste rajouter en ligne 117, 263, 264
Performance Comparison ReportSignificant Changes To Render DurationThere are no entries Meaningless Changes To Render DurationShow entries
Show details
Changes To Render CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
anoukhello
reviewed
Jul 31, 2023
| export const StatusBarBlurredBackground = ({ blurAmount = 8, blurType = 'light' }: Props) => { | ||
| const { top } = useCustomSafeInsets() | ||
|
|
||
| // There is an issue with the blur on Android: we chose not to render it and use a white background |
There was a problem hiding this comment.
Est-ce que tu peux ajouter le lien de l'issue github stp ?
There was a problem hiding this comment.
j'ai juste copier coller le commentaire de BlurView, j'ai plus le lien exact de l'issue :/
There was a problem hiding this comment.
Quand je dis lien exact, c'est que y en a plusieurs avec des problèmes liés à Android mais je retrouve pas celle qui le dit explicitement. Est ce que je mets un lien d'une de ces issues ?
There was a problem hiding this comment.
En regardant rapidement j'ai l'impression que celle ci parle du souci qu'on a rencontré non ? Kureev/react-native-blur#511
There was a problem hiding this comment.
Dans tous les cas oui ça peut être pas mal de mettre un lien
| blurType?: 'dark' | 'light' | 'xlight' | ||
| } | ||
|
|
||
| export const StatusBarBlurredBackground = ({ blurAmount = 8, blurType = 'light' }: Props) => { |
There was a problem hiding this comment.
D'après le code le composant BlurView a déjà ces propriétés :
export const BlurView = ({ blurAmount = 8, blurType = 'light' }: Props) => {
return <Blurred blurType={blurType} blurAmount={blurAmount} />
}
Est-ce vraiment nécessaire de les remettre ici ?
There was a problem hiding this comment.
Pas forcément, je les enlèvent
…kground on Android below the status bar
S4andro
force-pushed
the
PC-21416-blur-status-bar-home-and-profile
branch
from
b39bcf9 to
0d6dfa3
Compare
S4andro
force-pushed
the
PC-21416-blur-status-bar-home-and-profile
branch
from
0d6dfa3 to
629e27f
Compare
anoukhello
approved these changes
Jul 31, 2023
| export const StatusBarBlurredBackground = ({ blurAmount = 8, blurType = 'light' }: Props) => { | ||
| const { top } = useCustomSafeInsets() | ||
|
|
||
| // There is an issue with the blur on Android: we chose not to render it and use a white background |
There was a problem hiding this comment.
En regardant rapidement j'ai l'impression que celle ci parle du souci qu'on a rencontré non ? Kureev/react-native-blur#511
| export const StatusBarBlurredBackground = ({ blurAmount = 8, blurType = 'light' }: Props) => { | ||
| const { top } = useCustomSafeInsets() | ||
|
|
||
| // There is an issue with the blur on Android: we chose not to render it and use a white background |
There was a problem hiding this comment.
Dans tous les cas oui ça peut être pas mal de mettre un lien
tprache-pass
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-21416
Checklist
I have:
Screenshots