Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to python 3.11 #26

Closed
nutrina opened this issue Dec 14, 2022 · 4 comments · Fixed by #201
Closed

Upgrade to python 3.11 #26

nutrina opened this issue Dec 14, 2022 · 4 comments · Fixed by #201
Assignees

Comments

@nutrina
Copy link
Collaborator

nutrina commented Dec 14, 2022

Then we would be able to use: https://docs.python.org/3/library/datetime.html#datetime.datetime.fromisoformat
for parsing multiple formats of iso dates.

@nutrina nutrina added this to Passport Dec 14, 2022
@nutrina nutrina converted this from a draft issue Dec 14, 2022
@nutrina
Copy link
Collaborator Author

nutrina commented Jan 31, 2023

Support for python 3.11 might not yet be available for siwe and web3: ethereum/web3.py#2704

We might need an alternative to parsing the iso dates.

@erichfi
Copy link
Contributor

erichfi commented Mar 28, 2023

Whoever picks this, make sure web3 works on this Python version.

@aminah-io aminah-io moved this from Backlog to In Progress (WIP) in Passport Mar 31, 2023
@aminah-io aminah-io self-assigned this Mar 31, 2023
@aminah-io
Copy link
Collaborator

Looks like they added support for python 3.11 with this PR: ethereum/web3.py#2699

@aminah-io aminah-io assigned tim-schultz and unassigned aminah-io Mar 31, 2023
@nutrina
Copy link
Collaborator Author

nutrina commented Mar 31, 2023

Yes, that right, python 3.11 seems to be officially supported, it is listed here: https://pypi.org/project/web3/6.0.0/

@tim-schultz tim-schultz moved this from In Progress (WIP) to Product/UX Review in Passport Mar 31, 2023
@Kweiss Kweiss moved this from Product/UX Review to Ready to Deploy in Passport Apr 2, 2023
@nutrina nutrina moved this from Ready to Deploy to Done in Passport Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants