Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded BLOB url from Fido2MetadataServiceRepository.cs #443

Closed
joegoldman2 opened this issue Oct 11, 2023 · 1 comment · Fixed by #444
Closed

Remove hardcoded BLOB url from Fido2MetadataServiceRepository.cs #443

joegoldman2 opened this issue Oct 11, 2023 · 1 comment · Fixed by #444

Comments

@joegoldman2
Copy link
Contributor

We should probably remove the hardcoded BLOB url from Fido2MetadataServiceRepository.cs and change this line:

var httpClientBuilder = builder.Services.AddHttpClient(nameof(Fido2MetadataServiceRepository));

to something like:

var httpClientBuilder = builder.Services.AddHttpClient(nameof(Fido2MetadataServiceRepository), client =>
{
    client.BaseAddress = new Uri("https://mds3.fidoalliance.org/");
});

This will allow users to configure the url they want (especially when a new version is available) using the clientBuilder delegate from AddFidoMetadataRepository .

What do you think @abergs and @iamcarbon?

@aseigler
Copy link
Collaborator

Makes sense to me, as long as there is a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants