Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy option #80

Closed
wants to merge 6 commits into from
Closed

Proxy option #80

wants to merge 6 commits into from

Conversation

drizzef
Copy link

@drizzef drizzef commented Sep 25, 2017

Hi,

please review my code and add the option the add proxy.
i think the way that i did is not quite "clean" and right. maybe the proxy option should be outside of the properties but it is up to you.

love you module thanks it helped me a lot.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 98.077% when pulling 9105f28 on drizzef:master into 42a403c on pat310:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 98.077% when pulling 4940f39 on drizzef:master into 42a403c on pat310:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 98.077% when pulling 0d138c6 on drizzef:master into 42a403c on pat310:master.

@pat310
Copy link
Owner

pat310 commented Sep 25, 2017

@drizzef Anyway to do this without requiring a dependency?

@drizzef
Copy link
Author

drizzef commented Sep 27, 2017 via email

@turnerniles
Copy link

@drizzef How do you set up a proxy to forward the request? Also, do you have an array of proxys and the requests are then made from varying proxies?

@drizzef
Copy link
Author

drizzef commented Sep 27, 2017 via email

@Dayjo
Copy link

Dayjo commented Oct 6, 2017

This is a great idea!

As @pat310 said, it'd be nice to not need another dependency if possible. I also like @turnerniles suggestion of having the ability to use multiple proxies. Perhaps either you could specify which proxy during the request, or set it to 'random'.

The way that I do it at the moment is that I have 5 versions running behind different IPs (using Lambdas), and when my server calls it, it just chooses whichever one has been idle the longest so it seems to get a good rotation and not had any problems being blocked again so far.

@pat310
Copy link
Owner

pat310 commented Oct 6, 2017

@drizzef I was torn on whether we should include the proxy or not since it is a bit outside the scope of the module; however, there are constantly issues posted about how to increase the quota limit and although this does not completely fix the issue, it would help (like @Dayjo says). I am thinking we should include it.

It might be possible to set it up in a way such that the user can supply their own proxy client, then we don't need to include a dependency and the user can still easily set up a proxy if they choose. Thoughts?

@drizzef
Copy link
Author

drizzef commented Oct 7, 2017 via email

@pat310 pat310 mentioned this pull request Jan 27, 2018
@pat310
Copy link
Owner

pat310 commented Feb 1, 2018

Closed in #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants