Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Proxy Support #92

Merged
merged 3 commits into from
Feb 1, 2018
Merged

Enable Proxy Support #92

merged 3 commits into from
Feb 1, 2018

Conversation

aaronmefford
Copy link

Thanks for the great work on this Google Trends API, worked painlessly. However, I found I needed proxy support to be able to complete my task.

I modified the source and included is a pull request that makes it possible to include an agent value as part of the query, allowing specifying a proxy agent to the https request module.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 98.095% when pulling 89b28e2 on aaronmefford:master into 9c59b96 on pat310:master.

Copy link
Owner

@pat310 pat310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pat310
Copy link
Owner

pat310 commented Feb 1, 2018

closes #91

@pat310 pat310 mentioned this pull request Feb 1, 2018
@pat310 pat310 merged commit e6a579f into pat310:master Feb 1, 2018
@Dayjo
Copy link

Dayjo commented Feb 1, 2018

Very nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants