-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Outgoing Links #1
Comments
I responded in the thread but its probably better to have this discussion here. Are you referring to the functionality similar to what obsidian-no-dupe-leaves provides? Like when you click a link in the editor? |
One of the issues with no-dupe-leaves is that it monkey patches a core component of obsidian which I think will be frowned upon. I'll need to see if there is a different way to hook into the behavior. |
I have installed the "obsidian-no-dupe-leaves" plugin, but when I click Outing Links in preview mode, it still replaces the current tab instead of opening it in a new tab. |
So the idea is that when you click on a backlink inside a note, it should open in a new tab? |
Yes! |
Okay, let me try to hack on this when I get time. |
Appreciate~ |
@chenmaoran Released 1.0.5. You an update in BRAT42 |
Almost perfect now, only one problem. Links to headers in the same page also open in a new tab. That makes my table of contents not function as intended. Still better overall than the default behavior. |
Thanks for the report @willasm! Do you have an example page you could provide so i can test it? |
Sure, try this. # Table of contents
[[#Header 1]]
[[#Header 2]]
[[#Header 3]]
## Header 1
## Header 2
## Header 3 The links still go to the correct header, but open in another tab with a copy of the same file. |
I appreciate the help! Let me dig in. |
@willasm can you give 1.0.6 a try? It should fix the behavior around headings and blocks |
That fixed the example I gave you but I noticed one other method that does not work. # Table of contents 1
[[#Header 1]]
[[#Header 2]]
[[#Header 3|Alternate Name]]
# Table of contents 2
[[LinkDemo#Header 1]]
[[LinkDemo#Header 2]]
[[LinkDemo#Header 3]]
## Header 1
## Header 2
## Header 3 The first table of contents does work, but the second example does not. The only difference is the filename before the hashtag. I guess I could change my TOC template to just use the first method, but I suspect eventually someone else will notice this and bring this up. At any rate, great stuff and thank you very much for this. |
Let me take a look and try to fix it! Thanks for helping me debug it! |
@willasm 1.0.7 should fix the issue! |
Wow that was quick! I hope that I explained that clear enough? Here is an example.. [[CurrentFilename#Header 1]] This works!
[[SomeOtherFilename#Header 1]] This works but does not jump to Header 1 Thanks again!! |
That is amazing! v1.0.8 is working perfectly. Thanks again 👍 |
I actually found a weird case with backlinks in folders. 1.0.9 should fix it. Thanks for helping me debug this @willasm! |
This plugin works perfectly in File Explorer. It would be nice if it supported opening Outgoing Links, hopefully it will.
The text was updated successfully, but these errors were encountered: