Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default config should come first #1

Open
guipatriota opened this issue Jun 16, 2023 · 2 comments
Open

Default config should come first #1

guipatriota opened this issue Jun 16, 2023 · 2 comments

Comments

@guipatriota
Copy link
Contributor

guipatriota commented Jun 16, 2023

Hello, Patrik.

Just some suggestion. If you change the order and put:

'
  ' Default font styles
  '
  DefaultFontColor $color_fg
  ' https://github.com/twbs/bootstrap/blob/v4.5.3/scss/_variables.scss#L277
  DefaultFontName -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"
  ' DefaultFontSize
  ' DefaultFontStyle

  ' TODO: get this to work
  ' https://github.com/twbs/bootstrap/blob/v4.5.3/scss/_variables.scss#L278
  ' DefaultMonospacedFontName SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace

  ' DefaultTextAlignment

just after "skinparam {", all defaults will work and all specific changes, like DefaultFontColor to ClassFontColor will work too.

Have a nice day!
Guilherme.

@patrik-csak
Copy link
Owner

Thanks for the suggestion, @guipatriota

Is this what you mean? : 41dcd67

Do you have an example of something that doesn’t work but is fixed by your suggested change?

@guipatriota
Copy link
Contributor Author

Hi, Patrik.

That's exactly the change I made (41dcd67). I used your code as a starting point to create a theme in the style of DraculaPro Theme. However, I noticed that in some class and use case diagrams, the fonts, colors, and sizes were not being changed as expected. I even tried using DefaultMonospacedFontName instead of DefaultFontName. It only started working correctly after I placed these lines at the beginning of the skinparam.

In my code, I did:

skinparam {
  '
  ' Default font styles
  '  
  DefaultFontColor $color_pink
  DefaultFontName Fira Mono
  DefaultFontSize 20
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants