Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert - update a11y docs #3336

Closed
nicolethoen opened this issue Jan 11, 2023 · 0 comments · Fixed by #3348
Closed

Alert - update a11y docs #3336

nicolethoen opened this issue Jan 11, 2023 · 0 comments · Fixed by #3348
Assignees
@nicolethoen
Milestone
2023.01

Comments

@nicolethoen
Copy link
Collaborator

Update the alert a11y docs to reflect the changes made in patternfly/patternfly-react#8518

essentially, the Alert title might not need be a heading element if there is not description content below for it to be heading. A non-heading element like a span or a div could be used in that case. Also the titleHeadingLevel prop has been renamed to component prop.
@github-project-automation github-project-automation bot moved this to Not started in PatternFly Issues Jan 11, 2023
@nicolethoen nicolethoen mentioned this issue Jan 11, 2023
Merged
@mcarrano mcarrano added this to the 2023.01 milestone Jan 13, 2023
@nicolethoen nicolethoen mentioned this issue Jan 16, 2023
Merged
@nicolethoen nicolethoen moved this from Not started to PR Review in PatternFly Issues Jan 16, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.01
Development

Successfully merging a pull request may close this issue.

fix(Alert): update alert a11y to address title elements nicolethoen/patternfly-org
2 participants
@mcarrano @nicolethoen