Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoginPage - update LoginMainHeader wrapper to div #10879

Closed
thatblindgeye opened this issue Aug 26, 2024 · 0 comments · Fixed by #10880
Closed

LoginPage - update LoginMainHeader wrapper to div #10879

thatblindgeye opened this issue Aug 26, 2024 · 0 comments · Fixed by #10880
Assignees

Comments

@thatblindgeye
Copy link
Contributor

Describe the enhancement or change
Followup to patternfly/patternfly#6928 (comment) where we plan to update the header and footer elements being rendered inside the .pf-v6-c-login__main element to plain div wrappers. These elements lose their semantics when nested within sectioning content like main.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

@thatblindgeye thatblindgeye added this to the Penta final release milestone Aug 26, 2024
@thatblindgeye thatblindgeye self-assigned this Aug 26, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 26, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Not started in PatternFly Issues Aug 26, 2024
@kmcfaul kmcfaul linked a pull request Aug 27, 2024 that will close this issue
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Aug 28, 2024
@kmcfaul kmcfaul closed this as completed Aug 28, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants