-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(JumpLinks): Add replaceNavHistory option #11473
base: main
Are you sure you want to change the base?
feat(JumpLinks): Add replaceNavHistory option #11473
Conversation
Preview: https://patternfly-react-pr-11473.surge.sh A11y report: https://patternfly-react-pr-11473-a11y.surge.sh |
@@ -46,6 +46,8 @@ export interface JumpLinksProps extends Omit<React.HTMLProps<HTMLElement>, 'labe | |||
toggleAriaLabel?: string; | |||
/** Class for nav */ | |||
className?: string; | |||
/** Whether the navigation history should be replaced rather than pushed */ | |||
replaceNavHistory?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaceNavHistory?: boolean; | |
shouldReplaceNavHistory?: boolean; |
@@ -46,6 +46,8 @@ export interface JumpLinksProps extends Omit<React.HTMLProps<HTMLElement>, 'labe | |||
toggleAriaLabel?: string; | |||
/** Class for nav */ | |||
className?: string; | |||
/** Whether the navigation history should be replaced rather than pushed */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** Whether the navigation history should be replaced rather than pushed */ | |
/** Whether the current entry in the navigation history should be replaced when a JumpLinksItem is clicked. By default a new entry will be pushed to the navigation history. */ |
Maybe something like this for the description? Just to make it clear that only the current history item would be replaced rather than the entire history being replaced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ Eric's suggestions 👍
What:
Closes #11471