Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up use of menuAppendTo props on relevant components #7766

Closed
5 tasks done
nicolethoen opened this issue Jul 28, 2022 · 1 comment
Closed
5 tasks done

Clean up use of menuAppendTo props on relevant components #7766

nicolethoen opened this issue Jul 28, 2022 · 1 comment
Labels
Breaking change 💥 this change requires a major release and has API changes. PF5
Milestone

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Jul 28, 2022

By default, menuAppendTo should append 'inline' so that menus or poppers are always append to the trigger, in a popper, with absolute positioning so that the menus overlay the content below it.

Currently, selecting 'inline' for some components places the menu or other content after the trigger with static positioning so that it does not overlay the content below it. That should not be the case.

Also, once all menu like components are rebuilt to be constructed composably, they should not need a wrapper div by default, and the popper should be appended to the trigger 'inline' by default.

Work that needs to be done:

@nicolethoen nicolethoen added the Breaking change 💥 this change requires a major release and has API changes. label Jul 28, 2022
@tlabaj tlabaj added this to the Breaking Changes milestone Aug 24, 2022
@nicolethoen nicolethoen moved this to Breaking change in PatternFly Issues Sep 23, 2022
@mcarrano mcarrano modified the milestones: Breaking Changes, 2023.01 Nov 4, 2022
@mcarrano mcarrano modified the milestones: 2023.01, Breaking Changes Nov 29, 2022
@tlabaj tlabaj modified the milestones: Breaking Changes, 2023.03 Dec 16, 2022
@tlabaj tlabaj added the Epic label Dec 16, 2022
@tlabaj tlabaj modified the milestones: 2023.03, 2023.02 Dec 16, 2022
@nicolethoen nicolethoen moved this from Breaking change to Assigned but not started in PatternFly Issues Jan 24, 2023
@mcarrano mcarrano modified the milestones: 2023.02, 2023.03 Feb 2, 2023
@tlabaj
Copy link
Contributor

tlabaj commented Feb 14, 2023

all task have been completed

@tlabaj tlabaj closed this as completed Feb 14, 2023
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Feb 14, 2023
@nicolethoen nicolethoen added the PF5 label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change 💥 this change requires a major release and has API changes. PF5
Projects
Archived in project
Development

No branches or pull requests

3 participants