Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual list - Add empty state #8080

Closed
mmenestr opened this issue Sep 26, 2022 · 5 comments · Fixed by #8480
Closed

Dual list - Add empty state #8080

mmenestr opened this issue Sep 26, 2022 · 5 comments · Fixed by #8480
Assignees
Milestone

Comments

@mmenestr
Copy link
Collaborator

mmenestr commented Sep 26, 2022

Is this a new component or an extension of an existing one?
This is for an existing component: The dual list selector.

Describe the feature
Would like to add an empty state to the dual list selected that appears inside the "results" box when a search is applied that doesn't match any of the options.

Are there visuals for this feature? If applicable, please include examples for each state and for varying widths
No visuals, but here is a description: maybe just adding a small or xs empty state using the text and icon here: https://www.patternfly.org/v4/components/empty-state#no-match-found

Let me know if you do need a mock and I can whip one up!

cc: @nicolethoen

@nicolethoen
Copy link
Contributor

@mmenestr my only question is whether this empty state message should be different if there are no filters and it's just an empty list? That may be the starting state in many cases for the chosen options side of the dual list selector.

either way, I imagine a final solution here would also allow the user to override the empty state message and provide their own if they wanted.

@mmenestr
Copy link
Collaborator Author

Yes, we probably should have an empty state on the chosen side when there is nothing there as well, and maybe on the selection side too if all items have been selected and moved to the chosen side.

Proposed message for empty chosen side:
Header: No items have been chosen yet
Body: Use the arrows to select options from the available list

Proposed message for empty available list:
Header: No more available items
Body: All available items have been moved to the chosen list

But yes, I would probably allow for override if the use case calls for a different 'header' than "Available list" and "Chosen list"

@mcarrano
Copy link
Member

mcarrano commented Oct 7, 2022

@nicolethoen Will this issue require any core work, first?

@nicolethoen
Copy link
Contributor

I dont think so - only if they want to update any demos/examples to include the empty state

@mcarrano mcarrano added this to the 2023.02 milestone Oct 14, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Oct 21, 2022
@mcarrano mcarrano modified the milestones: 2023.02, 2022.16 Oct 26, 2022
@mmenestr
Copy link
Collaborator Author

mmenestr commented Nov 8, 2022

Here is a hacky mock for this:

image

Would want to use the XS Empty state, and for it to have a default message as shown above, with the option to customize if product teams want to! Empty state should be centered in the box.

@nicolethoen nicolethoen self-assigned this Nov 16, 2022
@mcarrano mcarrano modified the milestones: 2022.16, 2023.01 Dec 6, 2022
@nicolethoen nicolethoen moved this from Not started to In Progress in PatternFly Issues Jan 3, 2023
@nicolethoen nicolethoen moved this from In Progress to PR Review in PatternFly Issues Jan 3, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants