Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Alert - forcing text to be a heading is causing accessibility issues #8402

Closed
kdoberst opened this issue Dec 1, 2022 · 0 comments · Fixed by #8518
Closed

Bug - Alert - forcing text to be a heading is causing accessibility issues #8402

kdoberst opened this issue Dec 1, 2022 · 0 comments · Fixed by #8518
Assignees
Labels
Milestone

Comments

@kdoberst
Copy link

kdoberst commented Dec 1, 2022

Describe the problem
If an alert doesn't have any child elements, forcing the alert text to be a heading is an accessibility issue.

For example, if there is an inline alert with no children elements. The content in the title attribute isn't a header at all, in that it doesn't describe the content below it.

So if I have an inline alert, the content below the alert may not be described by the alert itself.

Here's an example:

<dl>
<dt>Service Level Agreement</dt>
<dd>
   Self-support, 60 day trial
   <Alert variant="warning" isInline isPlain title="1 day remaining" />
</dd>
<dt>Cluster ID</dt>
<dd>
my_crazy_long_cluster_id
</dd>
</dl>

The alert warning text of "1 day remaining" doesn't really describe what is below - in this case, the cluster ID. A header at any level is not appropriate in this case.

How do you reproduce the problem?
See the: https://www.patternfly.org/v4/components/alert

Expected behavior
If needed have the ability to have the text (aka title) wrapped in a non-heading tag (for example p, span, div).

Is this issue blocking you?
The only workaround is to create a custom component.

What is your product and what release date are you targeting?
OCM

Any other information?
This was originally reported as part of #6444 and that issue was closed without addressing this issue.

@patternfly-build patternfly-build moved this to Not started in PatternFly Issues Dec 1, 2022
@mcarrano mcarrano added this to the 2023.01 milestone Dec 2, 2022
@mcarrano mcarrano added Breaking change 💥 this change requires a major release and has API changes. and removed PF4 labels Jan 3, 2023
@mcarrano mcarrano modified the milestones: 2023.01, 2023.02 Jan 3, 2023
@mcarrano mcarrano added PF4 and removed Breaking change 💥 this change requires a major release and has API changes. labels Jan 3, 2023
@mcarrano mcarrano modified the milestones: 2023.02, 2023.01 Jan 3, 2023
@nicolethoen nicolethoen self-assigned this Jan 3, 2023
@nicolethoen nicolethoen moved this from Not started to PR Review in PatternFly Issues Jan 9, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
3 participants