Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - [All] - [react core esm packages should explicitely import the .mjs files from react-styles] #8871

Closed
KKoukiou opened this issue Mar 27, 2023 · 2 comments · Fixed by #9347
Assignees
Milestone

Comments

@KKoukiou
Copy link
Collaborator

Describe the problem
In cockpit we are importing files like import "@patternfly/react-core/dist/esm/components/Button/index.js";

I was recently analyzing the bundled output and noticed that the files that are imported from react-styles are not the .mjs ones but the plain CommonJS. This results in the use of 'require' instead of 'import'.

Screenshot from 2023-03-27 23-44-34

Expected behavior
I expect that the esm/ directory imports directly from the .mjs files from react-styles.

Is this issue blocking you?
No

@mcarrano
Copy link
Member

@dgutride thoughts? cc @nicolethoen

@nicolethoen nicolethoen added this to the 2023.06 milestone Mar 31, 2023
@nicolethoen nicolethoen modified the milestones: 2023.06, Post v5 priority May 2, 2023
@tlabaj tlabaj added P1 ⭐ and removed PF5 labels Jun 20, 2023
@nicolethoen nicolethoen moved this from Not started to Backlog in PatternFly Issues Jun 21, 2023
@nicolethoen nicolethoen moved this from Backlog to Not started in PatternFly Issues Jun 21, 2023
@wise-king-sullyman wise-king-sullyman moved this from Not started to In Progress in PatternFly Issues Jul 10, 2023
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Jul 11, 2023
@stale
Copy link

stale bot commented Sep 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
5 participants