Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - DatePicker - Initially skips over a month on arrow click #9700

Closed
jpuzz0 opened this issue Oct 2, 2023 · 3 comments · Fixed by #9722
Closed

Bug - DatePicker - Initially skips over a month on arrow click #9700

jpuzz0 opened this issue Oct 2, 2023 · 3 comments · Fixed by #9722
Assignees
@adamviktora
Milestone
2023.Q4

Comments

@jpuzz0
Copy link
Contributor

jpuzz0 commented Oct 2, 2023 •
edited
Loading

Describe the problem
Datepicker - when no value is provided and the current date is used as the initial date, clicking the arrow icon to shift to the next month results in a month being skipped over.

How do you reproduce the problem?
https://github.com/patternfly/patternfly-react/assets/96431149/8232400e-f0f0-4017-986f-8b5384c738db

Expected behavior
A month is not skipped over.

Is this issue blocking you?
Yes, it blocks quay from upgrading to the latest PF version of react-core.

Screenshots
If applicable, add screenshots to help explain the issue.

What is your environment?

  • macos
  • chrome
  • Version 117

What is your product and what release date are you targeting?
quay - mid November
@jpuzz0 jpuzz0 added the bug label Oct 2, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 2, 2023
@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Oct 2, 2023

The problem is related to this CalendarMonth component change:
8991db1

@jpuzz0 jpuzz0 mentioned this issue Oct 3, 2023
Merged
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Oct 4, 2023
@tlabaj tlabaj added this to the Prioritized Backlog milestone Oct 4, 2023
@wise-king-sullyman wise-king-sullyman moved this from Backlog to Not started in PatternFly Issues Oct 4, 2023
@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Oct 4, 2023 •
edited
Loading

As seen in this updated video reproduction, I also cannot go back to a previous month after navigating forward once, and am unable to select November in the dropdown:
https://github.com/patternfly/patternfly-react/assets/96431149/7c08cc7a-3fca-47ac-8b09-74b988e1c8d1

Once I've navigated back to October, I'm then able to proceed to November.

@adamviktora
Copy link
Contributor

Issue occurs when local timezone is UTC minus some hours, could not reproduce in local time in Czech Republic, where time is UTC+2, working on a fix now

@adamviktora adamviktora mentioned this issue Oct 9, 2023
Merged
@adamviktora adamviktora moved this from Not started to PR Review in PatternFly Issues Oct 9, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q4
Development

Successfully merging a pull request may close this issue.

fix(CalendarMonth): does not skip a month on arrow click adamviktora/patternfly-react
4 participants
@wise-king-sullyman @tlabaj @adamviktora @jpuzz0