Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover - Remove deprecated props #140

Closed
nicolethoen opened this issue Nov 23, 2022 · 0 comments · Fixed by #180
Closed

Popover - Remove deprecated props #140

nicolethoen opened this issue Nov 23, 2022 · 0 comments · Fixed by #180
Assignees
Labels
codemod pf5 codemod for p4 to p5 transition
Milestone

Comments

@nicolethoen
Copy link
Contributor

Follow up to breaking change PR patternfly/patternfly-react#8201

  • Any consumer references to Popover's boundary and tippyProps props should be removed.
  • Any consumers defining and passing Popover a shouldClose function with more than one parameter, needs to be given a warning that the first parameter has been removed (or we can remove it for them if possible).
  • Any consumers defining parameters as part of functions passed to the following Popover props should be warned that those function types have been updated to remove all parameters:
    • onHidden
    • onHide
    • onMount
    • onShow
    • onShown

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@kmcfaul kmcfaul self-assigned this Dec 7, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Dec 12, 2022
@nicolethoen nicolethoen added this to the 2023.01 milestone Dec 21, 2022
@nicolethoen nicolethoen moved this from Not started to PR Review in PatternFly Issues Jan 3, 2023
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jan 13, 2023
@gitdallas gitdallas added the pf5 codemod for p4 to p5 transition label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codemod pf5 codemod for p4 to p5 transition
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants