Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button - icons should now be passed to icon prop instead of as children #680

Closed
thatblindgeye opened this issue Jul 2, 2024 · 0 comments · Fixed by #689
Closed

Button - icons should now be passed to icon prop instead of as children #680

thatblindgeye opened this issue Jul 2, 2024 · 0 comments · Fixed by #689
Assignees
Labels

Comments

@thatblindgeye
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#10663

API of Button is being tweaked, icons should always be passed to icon prop. Codemod should move icons when the plain variant is applied, as that is the safest assumption that only an icon is being passed in.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants