Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button - Move icon children to the icon prop #716

Closed
wise-king-sullyman opened this issue Jul 25, 2024 · 0 comments · Fixed by #735
Closed

Button - Move icon children to the icon prop #716

wise-king-sullyman opened this issue Jul 25, 2024 · 0 comments · Fixed by #735
Assignees
@wise-king-sullyman
Labels
codemod
Milestone
Penta final release

Comments

@wise-king-sullyman
Copy link
Collaborator

wise-king-sullyman commented Jul 25, 2024 •
edited
Loading

Follow up to breaking change PR patternfly/patternfly-react#10663 and to help with patternfly/patternfly-react#10698

In the empty state codemod I was able to identify icon children and move those to the icon prop, we should do that for buttons as well rather than only moving icons for plain buttons.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta final release
2 participants
@wise-king-sullyman @tlabaj