Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dictionary operations __getitem__, __setitem__, __delitem__ #98

Closed
j123b567 opened this issue Jan 6, 2025 · 2 comments
Closed

Comments

@j123b567
Copy link

j123b567 commented Jan 6, 2025

In new rewrite, you are missing __getitem__, __setitem__, __delitem__.

I must thank you to write this library and we ware using it alot in the past. It was also a big inspiration to us.

Just to let you know, that we are not using it anymore, because of constant breaking API changes. This breaking change will make lot of your users unhappy.

@patx patx closed this as completed in 741cf05 Jan 6, 2025
@patx
Copy link
Owner

patx commented Jan 6, 2025

Thanks for pointing this out. Those were never meant to be left out. As for why your not using this anymore: The PyPI version hasn't been updated in years so API definetly has not changed unless you were using a development version on GitHub. I can think of 500 reasons to not use pickleDB and the changing API wouldn't even be close to the top of the list ;)

@j123b567
Copy link
Author

j123b567 commented Jan 6, 2025

This completely and silently breaks everything for us 89897b4

This causes exceptions on shutdown and was never addressed in released version (but fixed in master) 658fdda because of missing arguments in sigterm_handler

You are not using tags nor releases, so I can't map exact published versions. But these changes are pre 0.9.2.
These two things just prevent us from using the library.

From that point, we forked and later completely rewrite and simplified the library for our purpose so it has almost nothing in common with pickledb now. Similar to pkldb but derived from dict so it is no longer a DB but filesystem backed python dictionary. I have now uploaded it here https://gist.github.com/j123b567/dde7eb69ce3bf210d9bbd0999ad1b7b9 It is really a hack around dict so I don't want to propose this approche or make library from it.

Despite the fact that we no longer use this library, I have a certain debt to it because we used it a lot. I see some activity here so I just try to point out issues that you don't inadvertently discourage other users by breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants