Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make native addons built cross-platform #42

Merged
merged 3 commits into from
Apr 2, 2018
Merged

Make native addons built cross-platform #42

merged 3 commits into from
Apr 2, 2018

Conversation

paul-roman
Copy link
Member

shelljs is used to execute a Bash script that will:

  • Get the currently installed version number of Electron from package.json
  • Parse every directory inside scripts
  • Build the corresponding module with the Atom core corresponding to the Electron version number

Fix #41

Paul Roman added 3 commits April 2, 2018 19:29
Enhance forEach loops
358c840 
Use home-made package foreach-end
Fix #41 - Allow cross-platform built for native addons
82d625c 
Use shelljs to execute Bash script on Windows
Update .gitignore
cd796b1 
Ignore artifacts from native addons building
@paul-roman paul-roman self-assigned this Apr 2, 2018
@paul-roman paul-roman merged commit f36ccfe into master Apr 2, 2018
@paul-roman paul-roman deleted the dev branch April 2, 2018 22:22
@paul-roman paul-roman removed the idea label Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paul-roman paul-roman

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paul-roman