Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache potential games #57

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Cache potential games #57

merged 2 commits into from
Apr 27, 2018

Conversation

paul-roman
Copy link
Member

Potential games data fetched on IGDB is now cached in config/potential_games.json. Thanks to this:

  • IGDB API is no more queried every time a game is added
  • Potential games name and cover picture are locally stored, leading to performance enhancement
  • Potential games are crawled every time a game is deleted, since it no longer requires tons of time and resources

Fix #54

Paul Roman added 2 commits April 27, 2018 12:45
Add PotentialGamesCacher
eecb550 
Cache potential games into potential_games.json
Move IGDB research into PotentialGamesCacher
Fix #54
Remove personal settings from production build
86a7723
@paul-roman paul-roman added this to the 0.9.0 milestone Apr 27, 2018
@paul-roman paul-roman self-assigned this Apr 27, 2018
@paul-roman paul-roman merged commit 5ccb407 into master Apr 27, 2018
@paul-roman paul-roman deleted the next branch April 27, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paul-roman paul-roman

Labels
enhancement
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@paul-roman