Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degraded performance wkt.Unmarshal since v.0.9.1 #132

Closed
doqtri opened this issue Jun 29, 2023 · 2 comments
Closed

Degraded performance wkt.Unmarshal since v.0.9.1 #132

doqtri opened this issue Jun 29, 2023 · 2 comments

Comments

@doqtri
Copy link

doqtri commented Jun 29, 2023

Hi,

I've noticed the degraded performance of the method wkt.Unmarshal since v.0.9.1
Here is the comparison

v.0.9.0

BenchmarkUnmarshall_V90-10
BenchmarkUnmarshall_V90-10    	   55581	     21352 ns/op	   11384 B/op	     101 allocs/op

v.0.9.1

BenchmarkUnmarshall_V91-10
BenchmarkUnmarshall_V91-10    	    9172	    121703 ns/op	   17722 B/op	     180 allocs/op
@paulmach
Copy link
Owner

looks like

and then

There were a few issues about validation that these addressed. PRs welcome.

@paulmach
Copy link
Owner

performance has been improved to much greater than v0.9.0 levels in #142 See benchmarks in that PR.

The exception is very small geometries with multiple parts (multi*, polygon). The splitting of the parts still uses the regexp. However, in most cases the improvements to the "point parsing" will greatly out-way any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants