From 1cc931e6868f14a85a60a79cc4a382f531a91f6b Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Mon, 12 Oct 2020 16:26:13 -0700 Subject: [PATCH] [Dev Deps] update `eslint`, `@ljharb/eslint-config` --- .eslintrc | 1 + es6-shim.js | 3 ++- package.json | 4 ++-- test/promise/all.js | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.eslintrc b/.eslintrc index 7e2cb7b1..094e1d64 100644 --- a/.eslintrc +++ b/.eslintrc @@ -37,6 +37,7 @@ }], "no-invalid-this": [0], "no-invalid-regexp": [2, { "allowConstructorFlags": ["u", "y"] }], + "no-loss-of-precision": [1], "no-magic-numbers": [0], "no-native-reassign": [2, { "exceptions": ["Number", "Promise", "RegExp"] }], "no-negated-condition": [1], diff --git a/es6-shim.js b/es6-shim.js index 04c846c1..ce23c377 100644 --- a/es6-shim.js +++ b/es6-shim.js @@ -1057,7 +1057,8 @@ } if (typeof array !== 'undefined') { var len = ES.ToLength(array.length); - for (; i < len; i++) { + if (i < len) { + //for (; i < len; i++) { var kind = this.kind; var retval; if (kind === 'key') { diff --git a/package.json b/package.json index 69389fbb..c7cbb9b9 100644 --- a/package.json +++ b/package.json @@ -60,10 +60,10 @@ }, "dependencies": {}, "devDependencies": { - "@ljharb/eslint-config": "^17.1.0", + "@ljharb/eslint-config": "^17.2.0", "chai": "^3.5.0", "es5-shim": "^4.5.14", - "eslint": "^7.2.0", + "eslint": "^7.11.0", "evalmd": "0.0.19", "grunt": "^0.4.5", "grunt-contrib-connect": "^1.0.2", diff --git a/test/promise/all.js b/test/promise/all.js index e65813b7..a31b245a 100644 --- a/test/promise/all.js +++ b/test/promise/all.js @@ -162,7 +162,7 @@ describe('Promise.all', function () { if (hijack) { hijack = false; self = new Promise(function (resolve, reject) { - return resolver(function (values) { + resolver(function (values) { // record arguments & # of times resolve function is called actualArguments.push(values.slice()); return resolve(values);