Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown REST api correctly #1

Open
Babicaa opened this issue Mar 19, 2018 · 0 comments
Open

Shutdown REST api correctly #1

Babicaa opened this issue Mar 19, 2018 · 0 comments
Assignees

Comments

@Babicaa
Copy link
Member

Babicaa commented Mar 19, 2018

When the writer finishes, it might kill the REST Api in the middle of a request - it is a bit hard to reproduce, because it needs to happen on a very precise timing.

It was observed while running multiple scans in rapid succession at SF.

Need to change the current code not to call exit from the writing thread, but returning control to the REST thread and stopping the entire process.

Example:
https://github.com/ipkn/crow/blob/05d02fea6e2cf5d2603655419338995549993a8a/tests/unittest.cpp

@Babicaa Babicaa self-assigned this Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant