Test if _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR fixes segfaults on MSVC

paulsengroup · Oct 18, 2024 · 39c2006 · 39c2006
1 parent 28dfed0
commit 39c2006
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/pip.yml b/.github/workflows/pip.yml
@@ -48,7 +48,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [windows-2019, macos-latest, ubuntu-latest]
+        os: [windows-2022, macos-latest, ubuntu-latest]
         python-version: ["3.9", "3.12"]
 
     runs-on: ${{ matrix.os }}

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -160,12 +160,12 @@ if(WIN32)
 endif()
 
 if(MSVC)
-  if(MSVC_VERSION GREATER 1939)
-    message(
-      FATAL_ERROR
-      "MSVC versions after 19.39.33523.0 (and at least up to 19.42.34321.1) are known to produce broken hictkpy wheels. Please try again using MSVC 19.39.33523.0 (Visual Studio 17.9) or older."
-    )
-  endif()
+  # if(MSVC_VERSION GREATER 1939)
+  #   message(
+  #     FATAL_ERROR
+  #     "MSVC versions after 19.39.33523.0 (and at least up to 19.42.34321.1) are known to produce broken hictkpy wheels. Please try again using MSVC 19.39.33523.0 (Visual Studio 17.9) or older."
+  #   )
+  # endif()
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj")
 endif()