Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct pyproject.toml build-backend specification #107

Closed
nchepanov opened this issue Jan 20, 2021 · 4 comments · Fixed by #113
Closed

Correct pyproject.toml build-backend specification #107

nchepanov opened this issue Jan 20, 2021 · 4 comments · Fixed by #113

Comments

@nchepanov
Copy link
Contributor

Currently:

yaspin/pyproject.toml

Lines 75 to 77 in 2c78d24

[build-system]
requires = ["poetry>=0.12"]
build-backend = "poetry.masonry.api"

According to https://python-poetry.org/docs/pyproject/#poetry-and-pep-517

If your pyproject.toml file still references poetry directly as a build backend, you should update it to reference poetry_core instead.

Should be updated to,

[build-system]
requires = ["poetry_core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

This will significantly speed up the package installation process, since the entire poetry dependency cone is currently being installed during isolated build per PEP517.

I can submit a PR if no objections.

@pavdmyt
Copy link
Owner

pavdmyt commented Jan 20, 2021

Hi @nikitos3000

Thanks for pointing this out! I'll happily accept the PR.

@nchepanov
Copy link
Contributor Author

Hi @pavdmyt thank you for approving the PR. How do you feel about releasing a 1.3.1 version?

@pavdmyt
Copy link
Owner

pavdmyt commented Feb 18, 2021

I'll include this PR as well as a bunch of others in v1.4.0. If everything goes well, I'll do it this weekend.

@pavdmyt
Copy link
Owner

pavdmyt commented Feb 21, 2021

Included in yaspin v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants