Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type annotations to api #213

Closed
ionite34 opened this issue Oct 10, 2022 · 0 comments · Fixed by #214
Closed

Add return type annotations to api #213

ionite34 opened this issue Oct 10, 2022 · 0 comments · Fixed by #214

Comments

@ionite34
Copy link
Contributor

Proposal to add simple type hints for better IDE completions.

Currently the primary entry point is not annotated and resolves to Any type

yaspin/yaspin/api.py

Line 17 in 5692862

def yaspin(*args, **kwargs):

Resulting in no IDE completions:
yaspin1

If annotated with the return type -> Yaspin:
yaspin2
@ionite34 ionite34 mentioned this issue Oct 10, 2022
Merged
@ionite34 ionite34 changed the title Add type hints Add return type annotations to api Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add return type annotations to api ionite34/yaspin
1 participant
@ionite34