Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to reorder Bookmarks #187

Closed
TheSamDickey opened this issue Nov 16, 2021 · 5 comments · Fixed by #226
Closed

Ability to reorder Bookmarks #187

TheSamDickey opened this issue Nov 16, 2021 · 5 comments · Fixed by #226
Labels
🔨 Feature New feature or request

Comments

@TheSamDickey
Copy link

TheSamDickey commented Nov 16, 2021

Hello! I am an avid flame user and love the project. Thank you to everyone who has contributed to this; it is truly the best dashboard out there imo.

Feature Request:

It would be amazing if bookmarks could be reordered, in the same way that applications and bookmark categories can be reordered. I have quite a few bookmarks, and there are a handful I really wish I could move around.

Has this been discussed before? I would be interested to know if others would also find this useful.

Note: I am unsure if it has to do with permissions, but I am unable to add a Feature Request label to this. Sorry about that!

@Brancliff
Copy link

Seconding this - you can click-and-drag to reorganize your applications, but you can't reorganize your bookmarks at all. It seems like an odd omission

@ghost
Copy link

ghost commented Nov 19, 2021

I was surprised that this hasn't been implemented when the order of applications can be changed so easily in the same way we'd expect bookmarks to also. Please consider adding this functionality.

@pawelmalak
Copy link
Owner

you can click-and-drag to reorganize your applications, but you can't reorganize your bookmarks at all. It seems like an odd omission

I was surprised that this hasn't been implemented when the order of applications can be changed so easily

That's because apps exist in a single dimensional array so reordering them comes down to simple index value changing. Bookmarks however, exist in two dimensional array. They are nested within categories array which is also single dimensional. Because we have one table to access and edit all bookmarks it's not possible to implement custom order here (can't set shared order index value between multiple arrays). The only way it could be implemented is to move bookmark editing into separate table. So to edit or reorder bookmarks you would have to first choose category and then access its bookmarks for edit.

@TheSamDickey
Copy link
Author

@pawelmalak Thank you for the insight on this. I feel like the requirement of clicking into category, then accessing its bookmarks for edits is a pretty intuitive way of doing it.

Do you think that this addition would be okay to have? If so, is this something that I should attempt to do and make a PR for?

@Brancliff
Copy link

Oh, I'm glad there's a reasonable technical explanation for it. I don't know how this sort of stuff works - I'm not a software engineer, I'm just some kid with a NAS

But- not only would a separate table for bookmarks fix the inability to reorganize them, I think it'd be a great change anyway! Editing your bookmarks can get more cumbersome the more of them you have - if you have a long list of them, there can be a lot of scrolling up and down to do a lot of editing. You can try to ctrl + F to jump to a specific one, but if you need to edit more than one, it can only help so much.

Right now, clicking on the name of a bookmark category doesn't do anything (either from the main menu or the bookmarks menu), so I think that would be a good place to put it.

@pawelmalak pawelmalak added the 🔨 Feature New feature or request label Nov 22, 2021
@pawelmalak pawelmalak linked a pull request Nov 25, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants