feat: autolabel fields when omitted #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocks must have a label for pill text. |
denolfe
force-pushed
the
field-autolabel
branch
from
d32f6d2
to
a5315c9
Compare
|
Ready for review |
jmikrut
reviewed
Feb 5, 2021
src/admin/components/forms/DraggableSection/ActionPanel/types.ts
Outdated
Show resolved
Hide resolved
jmikrut
reviewed
Feb 5, 2021
jmikrut
reviewed
Feb 5, 2021
jmikrut
reviewed
Feb 5, 2021
denolfe
force-pushed
the
field-autolabel
branch
from
79d2916
to
c57d688
Compare
jmikrut
reviewed
Mar 8, 2021
| @@ -7,6 +7,7 @@ export type Props = Omit<ArrayField, 'type'> & { | |||
| path?: string | |||
| fieldTypes: FieldTypes | |||
| permissions: FieldPermissions | |||
| label: string | |||
There was a problem hiding this comment.
This should also be allowed to be set to false as well, right? As the Blocks type?
There was a problem hiding this comment.
Ugh, changing this one had a lot of implications, let's discuss.
jmikrut
reviewed
Mar 8, 2021
denolfe
force-pushed
the
field-autolabel
branch
2 times, most recently
from
6bc7c64
to
195932d
Compare
jacobsfletch
pushed a commit
to jacobsfletch/payload
that referenced
this pull request
Oct 15, 2023
jacobsfletch
pushed a commit
to jacobsfletch/payload
that referenced
this pull request
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label: falseopts out of getting labeledlabel: 'My Custom Label'overrides auto-labelingResolves #37