This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Delay instantation of brcast in ThemeProvider so it can be inited wit… #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h correct initialState
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 179 181 +2
Branches 50 51 +1
=====================================
+ Hits 179 181 +2
Continue to review full report at Codecov.
|
paulmolluzzo
approved these changes
Dec 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h correct initialState
What:
Delayed initialization of brcast to
componentWillMountWhy:
So it won't ever get "untrue" initialState in case of nested ThemeProviders
Checklist:
This is a follow up PR to the discussion here