Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

CSS function recursion #391

Merged
merged 2 commits into from
Mar 2, 2018
Merged

CSS function recursion #391

merged 2 commits into from
Mar 2, 2018

Conversation

quicksnap
Copy link
Collaborator

@quicksnap quicksnap commented Mar 2, 2018

This approach simply unwinds functions until it gets a non-function, then recurses normally.

What:

Style function recursion. Closes #390

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

codecov-io commented Mar 2, 2018

Codecov Report

Merging #391 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #391   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         182    177    -5     
  Branches       52     50    -2     
=====================================
- Hits          182    177    -5
Impacted Files Coverage Δ
src/get-glamor-classname.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c2376...ece832e. Read the comment docs.

@quicksnap
Copy link
Collaborator Author

Ok, added a test and it's working good! Ready to go.

Copy link
Contributor

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks so much!

@kentcdodds kentcdodds merged commit b09d05f into paypal:master Mar 2, 2018
@quicksnap
Copy link
Collaborator Author

Neat! Thanks for merging so quickly. How often do you cut releases?

@quicksnap quicksnap deleted the recurse-style branch March 2, 2018 22:32
@kentcdodds
Copy link
Contributor

Immediately and automatically :) This was published a few minutes ago as 4.12.0 👍

@kentcdodds
Copy link
Contributor

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@quicksnap
Copy link
Collaborator Author

💃 💃 💃 💃 💃 💃 💃 💃 💃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants