Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetLatestWatcherMetrics did not return proper error #27

Closed
wangchen615 opened this issue Apr 1, 2021 · 1 comment
Closed

GetLatestWatcherMetrics did not return proper error #27

wangchen615 opened this issue Apr 1, 2021 · 1 comment
Labels
bug Something isn't working question Further information is requested
Milestone
v0.2.0

Comments

@wangchen615
Copy link
Collaborator

GetLatestWatcherMetrics can return nil, nil in case of e.g. HTTP error code 403. (

load-watcher/pkg/watcher/api/client.go

Line 107 in 6c7e96e

klog.Errorf("received status code %v from watcher", resp.StatusCode)
)
Why GetLatestWatcherMetrics return nil, nil instead of just returning a proper error in this case?

@zorro786
@wangchen615 wangchen615 added bug Something isn't working question Further information is requested labels Apr 1, 2021
@zorro786
Copy link
Contributor

zorro786 commented Apr 1, 2021

@wangchen615 Looks like a bug, should return err there.

@zorro786 zorro786 added this to the v0.2.0 milestone Aug 27, 2021
@zorro786 zorro786 mentioned this issue Aug 30, 2021
Merged
@zorro786 zorro786 closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@zorro786 @wangchen615