Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fix logo images for other color buttons #94

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

jshawl
Copy link
Contributor

@jshawl jshawl commented Feb 14, 2023

Before:
Screen Shot 2023-02-14 at 11 35 20

After:
Screen Shot 2023-02-14 at 11 31 08

TODO

After merge, update paypal-checkout-components npm run jest-screenshot

@jshawl jshawl marked this pull request as ready for review February 14, 2023 17:36
@jshawl jshawl requested a review from a team as a code owner February 14, 2023 17:36
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 73.27% // Head: 73.27% // No change to project coverage 👍

Coverage data is based on head (9dc6123) compared to base (f1dce0f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files          41       41           
  Lines         348      348           
  Branches       36       36           
=======================================
  Hits          255      255           
  Misses         90       90           
  Partials        3        3           
Impacted Files Coverage Δ
src/logos/bank/glyph/logo.jsx 25.00% <ø> (ø)
src/constants.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jshawl jshawl requested a review from nbierdeman February 14, 2023 17:38
@dtjones404 dtjones404 merged commit 6d84a30 into paypal:main Feb 14, 2023
@jshawl jshawl deleted the DTCHKINT-1420 branch February 14, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants