chore: create separate components for inline and external svgs #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 73.27% 75.16% +1.88%
==========================================
Files 41 41
Lines 348 467 +119
Branches 36 65 +29
==========================================
+ Hits 255 351 +96
- Misses 90 113 +23
Partials 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dtjones404
force-pushed
the
component-split
branch
from
58f0d0c to
064e708
Compare
gregjopa
reviewed
Mar 7, 2023
src/logos/applepay/logo.jsx
Outdated
| alt="Apple Pay" | ||
| aria-label="Apple Pay" | ||
| cdnUrl={cdnUrl} | ||
| render={() => { |
There was a problem hiding this comment.
Do we still need the render() function for these ExternalImage components?
There was a problem hiding this comment.
We shouldn't. I'll see about getting it removed!
gregjopa
changed the title
gregjopa
approved these changes
Mar 7, 2023
dtjones404
force-pushed
the
component-split
branch
from
8614b28 to
b79627d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.