Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Should react-redux be a peer dependency? #202

Open
aneeshvaidya opened this issue Nov 6, 2017 · 5 comments
Open

Should react-redux be a peer dependency? #202

aneeshvaidya opened this issue Nov 6, 2017 · 5 comments

Comments

@aneeshvaidya
Copy link
Contributor

I recently upgraded to react-engine 4.4.0, and now I'm seeing an error in my build script where react-redux is not found, due to the redux support addition.

@jonathansamines
Copy link
Contributor

Yes, I am also experienced this issue when updating my react-engine version. Seems like even when the dependency is imported conditionally, webpack is trying to import it and it fails because of it. I wouldn't mind to install the dependency, however some projects don't use redux at all so this solution is not optimal for everyone.

Perhaps is just a matter to change something in my webpack configuration, ideas?

@aneeshvaidya
Copy link
Contributor Author

I believe this will likely solve the issue: http://remarkablemark.org/blog/2017/02/25/webpack-ignore-module/

@clintandrewhall
Copy link

I have this issue with Browserify.

@jonathansamines
Copy link
Contributor

@aneeshvaidya Using webpack.IgnorePlugin worked for us. Thanks!

@ashok-kumar
Copy link

ashok-kumar commented Mar 4, 2018

Same error with latest version of react-engine.

ERROR in ./~/react-redux/lib/connect/mapDispatchToProps.js
Module not found: Error: Cannot resolve module 'redux' in .../../../node_modules/react-redux/lib/connect
 @ ./~/react-redux/lib/connect/mapDispatchToProps.js 8:13-29

@aneeshvaidya Ignoring module works in this case. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants