Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

What the viewResolver actually is? #40

Open
gocreating opened this issue Jun 12, 2015 · 2 comments
Open

What the viewResolver actually is? #40

gocreating opened this issue Jun 12, 2015 · 2 comments

Comments

@gocreating
Copy link
Contributor

1. The path problem

I use console.log() to print the parameter viewName and find that it is an absolute path in my project but a relative path in react-engine example.

That's really really really unreasonable.....

2. Few document for the purpose of this function

The only docs on this function is in README page:

supply a function that can be called to resolve the file that was rendered

so who will call this function?
when it would be called?
and what is the parameter viewName mean?

This function does matter!!!
The whole view engine won't work correctly without correct viewResolver but there is only one line of explanation

@joshhornby
Copy link

Would love to hear an answer for this as well.

@gocreating
Copy link
Contributor Author

@joshhornby
For problem 1 you can see this: #41
I've fixed it, just no more than 3 lines of modification

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants