v0.18.0 #328
Merged
v0.18.0 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was re-written in order to fix a number of performance issues with the original implementation. Allocations were high and this function is used a lot, this new implementation is much lighter on string allocations by using a string builder.
This function runs a lot and `syncMapToMap` is slow. The function is idepmotent so a cache prevents a lot of un-nessecary burn.
The function uses `equalFold` so this call is wasteful and slow.
This was stupid and I regret doing this. It causes tons of issues downstream.
Not sure how I missed these, however, better late than never.
stupid thing is throwing 404’s today for the latest release. Screw it, lock it down!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.02%
==========================================
Files 164 164
Lines 16597 16640 +43
==========================================
+ Hits 16537 16578 +41
- Misses 55 57 +2
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved memory handling and performance in utility functions and component schema lookup.