Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by one error #329

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix off by one error #329

merged 1 commit into from
Sep 11, 2024

Conversation

daveshanley
Copy link
Member

Fixes an off by one error discovered in the platform.

Saw this blow up in the platform today. Silly me.
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (efe5523) to head (3304967).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         164      164           
  Lines       16674    16674           
=======================================
+ Hits        16614    16615    +1     
+ Misses         55       54    -1     
  Partials        5        5           
Flag Coverage Δ
unittests 99.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley daveshanley merged commit 8e9d97c into main Sep 11, 2024
4 checks passed
@daveshanley daveshanley deleted the v0.18.1 branch November 30, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant