Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base64.a85decode from stdlib #602

Open
ciupicri opened this issue Apr 7, 2021 · 1 comment · May be fixed by #1031
Open

Use base64.a85decode from stdlib #602

ciupicri opened this issue Apr 7, 2021 · 1 comment · May be fixed by #1031
Labels
component:parser Related to PDFParser status: accepted type: development Related to the development process for maintainers

Comments

@ciupicri
Copy link

ciupicri commented Apr 7, 2021

The standard library has a function named a85decode in the base64 module, perhaps we could use it instead of our custom implementation.

The difference is that it requires a parameter to differentiate between the "standard" and the Adobe Ascii85 formats.
@pietermarsman
Copy link
Member

Great tip!

@pietermarsman pietermarsman added type: development Related to the development process for maintainers component:parser Related to PDFParser status: accepted labels Aug 7, 2022
@dhdaines dhdaines linked a pull request Aug 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:parser Related to PDFParser status: accepted type: development Related to the development process for maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use built-in functions for ascii85 and asciihex dhdaines/pdfminer.six
2 participants
@ciupicri @pietermarsman