GNU licence in dependencies

[pettzilla1]

The original PDF miner only had a BSD 2 licence required in the dependencies , six requires chardet which reduces the usability of the package due to it being GNU might I suggest its replaced with "charset_normalizer" which is MIT , while also being well maintained.

[pietermarsman]

I'm not an expert in licences. Can you rephrase your post to explain better what the situation is and what you want?

[pettzilla1]

Though pdfminer.six has an MIT license using it as part of a service causes problems as one of the dependencies in this case “chardet” has a gnu license which means you would have to distribute your source code with whatever system you make which isn’t ideal so technically pdfminer.six is made to have this requirement as you need to install “chardet” for it to work.

"charset_normalizer" Is MIT and has a similar functionality to “chardet” by using it instead I don’t believe there would then be a requirement to distribute source code with any system that used pdfminer.six.

would it be possible to use "charset_normalizer" instead of “chardet” ? it would make the overall package a lot more useable.

[pietermarsman]

Seems like it is an improvement on many levels: more coverage, faster and better licence.

Also, the requests library is using it as well so it is probably mature enough.

Will create a PR for this.

[pietermarsman]

@pettzilla1 can you review my PR?

[pettzilla1]

I've reviewed @pietermarsman but don't have write access, So I believe someone else will need to as well

[pettzilla1]

@jstockwin would you be able to review the PR?

[jstockwin]

Done 👍

[pettzilla1]

@pietermarsman thanks for the help with this issue , The PR has been reviewed 👍