Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No lockfile is committed #43

Closed
Tracked by #51
Vinnl opened this issue Dec 28, 2020 · 2 comments
Closed
Tracked by #51

No lockfile is committed #43

Vinnl opened this issue Dec 28, 2020 · 2 comments
Assignees
Labels
question Further information is requested
Milestone

Comments

@Vinnl
Copy link

Vinnl commented Dec 28, 2020

I tried to run php-solid-server on Heroku to give it a look-over, but my deployment is immediately rejected:

ERROR: No 'composer.lock' found!

A 'composer.lock' file was not found in your project, but there
is a 'composer.json' file with dependencies inside 'require'.

The lock file is required in order to guarantee reliable and
reproducible installation of dependencies across platforms and
deploys. You must follow the Composer best practice of having
your lock file under version control in order to deploy. The
lock file must not be in your '.gitignore'.

Please perform the following steps locally on your computer to
resolve this issue before attempting another deploy:

  1. remove 'composer.lock' from file '.gitignore', if present
  2. if no 'composer.lock' exists, run 'composer update'
  3. stage the lock file changes using 'git add composer.lock'
  4. if you edited '.gitignore', also run 'git add .gitignore'
  5. commit the change using 'git commit'

Please remember to always keep your 'composer.lock' updated in
lockstep with 'composer.json' to avoid common problems related
to dependencies during collaboration and deployment.

Please refer to the Composer documentation for further details:
https://getcomposer.org/doc/
https://getcomposer.org/doc/01-basic-usage.md

Aside from Heroku deployments, although I'm not too familiar with the PHP ecosystem, I assume it would be a good idea to commit a lockfile to prevent "works on my machine" issues as well.

(On a tangential note: there's no hosted instance of the server available somewhere that I can run automated tests against, is there?)

@Potherca Potherca added the question Further information is requested label Dec 28, 2020
@Potherca Potherca self-assigned this Dec 28, 2020
@Potherca
Copy link
Member

Hi! Thank you for bringing this to our attention!

It is considered good practice to commit the lock file to a repository.

The reason we haven't done this yet is becasue are simultaneously developing this standalone version, a Nextcloud version, and the packages that power both.

Some parts are still under heavy development and everything is still somewhat in flux. That is also the reason no hosted instance is live yet.

We are currently in the process of rounding up loose ends, so this is good time for us to start thinking about releasing a deployable version (including a lock file).

We'll keep you posted of any developments on that front here! 👍

@Vinnl
Copy link
Author

Vinnl commented Dec 29, 2020

Great, looking forward to that!

@Potherca Potherca added this to the v0.5.0 milestone Oct 21, 2021
@Potherca Potherca mentioned this issue Nov 11, 2021
6 tasks
@Potherca Potherca modified the milestones: v0.5.0, v0.6.0 Nov 24, 2021
@Potherca Potherca modified the milestones: v0.6.0, v0.5.0 Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants