Fk 4 #23
Open
Fk 4 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
pdybowski
requested changes
Dec 9, 2021
src/modules/Jobs/jobs.module.js
Outdated
Comment on lines
35
to
55
| const offerBox = document.createElement('div'); | ||
| offerBox.classList.add('jobOffers__offerBox', 'position-relative', 'shadow', 'p-3', 'mb-5', 'bg-light', 'rounded'); | ||
| const offerHeader = document.createElement('h4'); | ||
| offerHeader.classList.add('fs-4') | ||
| const offerCompanyName = document.createElement('p'); | ||
| const offerLocalization = document.createElement('p'); | ||
| offerLocalization.classList.add('fw-light') | ||
| const offerSalary = document.createElement('span'); | ||
| offerSalary.classList.add('fw-light') | ||
| const button = document.createElement('a'); | ||
| button.setAttribute('href', job.redirect_url) | ||
| button.setAttribute('target', '_blank') | ||
| button.classList.add('jobOffers__offerBox--button', 'position-absolute', 'bottom-0', 'start-50', 'translate-middle-x') | ||
| button.innerText = 'Show more!'; | ||
| let minSalary = job.salary_min ? job.salary_min : 'unknow'; | ||
| let maxSalary = job.salary_max ? job.salary_max : 'unknow'; | ||
|
|
||
| offerHeader.innerText = job.title ? job.title : 'No title for this role'; | ||
| offerCompanyName.innerText = job.company.display_name ? job.company.display_name : null; | ||
| offerLocalization.innerText = job.location.display_name ? job.location.display_name : 'Location unknown'; | ||
| offerSalary.innerText = `min. salary: ${minSalary} || max. salary: ${maxSalary}`; |
There was a problem hiding this comment.
please put this all in separate methods like:
const offerHeader = _createOfferHeader()
const offerBox = _createOfferBox()
...
|
@pdybowski done |
pdybowski
requested changes
Dec 17, 2021
|
|
||
|
|
||
| _renderContent(data) { | ||
| const containerWithJobOffers = document.createElement('div'); |
There was a problem hiding this comment.
we have createElement util to create elements
pdybowski
requested changes
Dec 17, 2021
| this.APP_ID = '07300533'; | ||
| this.APP_KEY = 'fadda830981b47b9ef3e023f82b349ca'; | ||
| this.URL = `https://api.adzuna.com/v1/api/jobs/pl/search/1?app_id=${this.APP_ID}&app_key=${this.APP_KEY}`; | ||
| this.fetchedData; |
| export class Jobs { | ||
| constructor() { | ||
| this.viewElement = document.querySelector('#main'); | ||
| this.APP_ID = '07300533'; |
There was a problem hiding this comment.
these fields should be taken from envirnoment file
| fetch(this.URL) | ||
| .then(response => response.json()) | ||
| .then(data => this._renderContent(data.results)) | ||
| .catch(error => this.fetchError = error); |
There was a problem hiding this comment.
please use Notification class to show errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Jobs module with list of job offers