Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add disable_nojekyll and cname options #119

Merged
merged 13 commits into from
Feb 24, 2020
Merged

Conversation

peaceiris
Copy link
Owner

@peaceiris peaceiris commented Feb 20, 2020

  • Add .nojekyll file by default to only the master and gh-pages branches. When the file already exists, this action does nothing.
  • When we set other branches to publish_branch, this action does not add .nojekyll file.

cf. #112

Co-authored-by: Daniel Himmelstein daniel.himmelstein@gmail.com
Co-authored-by: Nicolas Vanhoren nicolas.vanhoren@gmail.com

peaceiris and others added 5 commits February 20, 2020 16:10
- Add .nojekyll file by default for only the master and gh-pages branches. When the file already exists, this action does nothing.
- When we set other branches to publish_dir, this action does not add .nojekyll file.

cf. #112

Co-authored-by: Daniel Himmelstein <daniel.himmelstein@gmail.com>
Co-authored-by: Nicolas Vanhoren <nicolas.vanhoren@gmail.com>
@peaceiris
Copy link
Owner Author

peaceiris commented Feb 20, 2020

- name: Deploy
  uses: peaceiris/actions-gh-pages@v3.3.0-0
  with:
    deploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}
    # github_token: ${{ secrets.GITHUB_TOKEN }}
    # personal_token: ${{ secrets.PERSONAL_TOKEN }}
    publish_dir: ./public
    disable_nojekyll: true
    cname: peaceiris.com

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6244b19). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage          ?   95.58%           
=========================================
  Files             ?        2           
  Lines             ?       68           
  Branches          ?       14           
=========================================
  Hits              ?       65           
  Misses            ?        3           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6244b19...60bd7aa. Read the comment docs.

@peaceiris peaceiris marked this pull request as ready for review February 24, 2020 09:44
@peaceiris peaceiris merged commit 00fde1e into master Feb 24, 2020
@peaceiris peaceiris deleted the feat-nojekyll-cname branch February 24, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant