Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop ubuntu-18.04, add 22.04, latest #776

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

imomaliev
Copy link
Contributor

@imomaliev imomaliev commented Aug 29, 2022

@peaceiris peaceiris added cicd docker Pull requests that update Docker code documentation labels Aug 29, 2022
peaceiris
peaceiris previously approved these changes Aug 29, 2022
Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! ʕ◔ϖ◔ʔ

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 61.45% // Head: 61.45% // No change to project coverage 👍

Coverage data is based on head (722f0b2) compared to base (05d272d).
Patch has no changes to coverable lines.

❗ Current head 722f0b2 differs from pull request most recent head f3c33ff. Consider uploading reports for the commit f3c33ff to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files           4        4           
  Lines         275      275           
  Branches       45       45           
=======================================
  Hits          169      169           
  Misses        105      105           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imomaliev
Copy link
Contributor Author

@peaceiris Dev image step broke( I will look into this.

@imomaliev
Copy link
Contributor Author

@peaceiris Dev image build should be fixed now.

@peaceiris peaceiris added the dependencies Pull requests that update a dependency file label Aug 30, 2022
@imomaliev
Copy link
Contributor Author

imomaliev commented Aug 30, 2022

@peaceiris Sorry. It turns out it works with curl -fsSL "https://deb.nodesource.com/setup_${NODE_VERSION}" but with curl -fsSL "https://deb.nodesource.com/setup_${NODE_VERSION%%.*}" doesn't. Fails with node version 12.x not being supported by ubuntu-22.04. Updated nodejs version to the latest LTS 16.17.0. make build locally worked

@imomaliev
Copy link
Contributor Author

@peaceiris Hi. Just wanted to ask if you have any feedback for this PR?

If you are currently busy or do not have time to look into this, that is ok, this is not urgent. I know that opensource maintenance could be very taxing.

@peaceiris
Copy link
Owner

peaceiris commented Sep 4, 2022

Could you revert the changes to the .nvmrc and Dockerfile? I will work on bumping the node version in my task.

@peaceiris peaceiris removed dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Sep 4, 2022
@imomaliev
Copy link
Contributor Author

@peaceiris Done. Rolled back all changes to .nvmrc and Dockerfile Also squashed commits to one

@imomaliev
Copy link
Contributor Author

imomaliev commented Sep 4, 2022

Also, if you give me directions on what your plan is I could pick up your PR for node upgrade. I assume it is this one #539.

Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. 👍

@peaceiris peaceiris changed the title ci: drop ubuntu-18.04, add ubuntu-22.04 and ubuntu-latest ci: drop ubuntu-18.04, add 22.04, latest Sep 4, 2022
@peaceiris peaceiris merged commit 2eea5d7 into peaceiris:main Sep 4, 2022
@ataljka ataljka mentioned this pull request Sep 4, 2022
@imomaliev imomaliev deleted the ubuntu-2204 branch September 4, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants