Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for different processor architectures #518

Merged
merged 1 commit into from
May 27, 2021
Merged

feat: Add support for different processor architectures #518

merged 1 commit into from
May 27, 2021

Conversation

steveteuber
Copy link
Contributor

@steveteuber steveteuber commented May 20, 2021

Hey @peaceiris.

First, thanks for this really great github action!
In this pull request, I want to add support for different processor architectures.

Currently, I'm using a custom runner on an Apple Silicon M1...
And this action only installs the 64bit release of Hugo.

src/get-arch.ts Outdated Show resolved Hide resolved
Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent ʕ◔ϖ◔ʔ!

src/get-arch.ts Outdated Show resolved Hide resolved
__tests__/get-arch.test.ts Show resolved Hide resolved
src/get-arch.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #518 (4261360) into main (b843eae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         7    +1     
  Lines          124       140   +16     
  Branches        14        20    +6     
=========================================
+ Hits           124       140   +16     
Impacted Files Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)
src/get-arch.ts 100.00% <100.00%> (ø)
src/get-os.ts 100.00% <100.00%> (ø)
src/get-url.ts 100.00% <100.00%> (ø)
src/installer.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bdbf1...4261360. Read the comment docs.

@peaceiris peaceiris added the enhancement New feature or request label May 24, 2021
Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ʕ◔ϖ◔ʔ 👍

@peaceiris peaceiris changed the title Feat: Add support for different processor architectures feat: Add support for different processor architectures May 27, 2021
@peaceiris peaceiris merged commit 6d30a88 into peaceiris:main May 27, 2021
@peaceiris
Copy link
Owner

@steveteuber Could you try the release v2.5.0?

@steveteuber steveteuber deleted the arch branch May 27, 2021 07:07
@steveteuber
Copy link
Contributor Author

@peaceiris Works like a charm. Thank you!

@peaceiris
Copy link
Owner

Thank you for the great contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants