test: Enhance test case name (#39)

* test: Remove should * test: Rename test case title
peaceiris · Jan 10, 2020 · 7cab470 · 7cab470
1 parent 6ad5947
commit 7cab470
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/__tests__/get-latest-version.test.ts b/__tests__/get-latest-version.test.ts
@@ -18,7 +18,7 @@ const urlBrewExpected: string = `https://formulae.brew.sh/api/formula/${repo}.js
 const urlGithubExpected: string = `https://api.github.com/repos/${org}/${repo}/releases/latest`;
 
 describe('getURL()', () => {
-  test('should return expected URL', () => {
+  test('return expected URL', () => {
     const urlBrew: string = getURL(org, repo, 'brew');
     const urlGithub: string = getURL(org, repo, 'github');
 
@@ -30,7 +30,7 @@ describe('getURL()', () => {
 describe('getLatestVersion()', () => {
   let versionLatestExpected: string = '0.3.5';
 
-  test('should return latest version via brew', async () => {
+  test('return latest version via brew', async () => {
     nock('https://formulae.brew.sh')
       .get(`/api/formula/${repo}.json`)
       .reply(200, jsonTestBrew);
@@ -39,7 +39,7 @@ describe('getLatestVersion()', () => {
     expect(versionLatest).toMatch(versionLatestExpected);
   });
 
-  test('should return latest version via GitHub', async () => {
+  test('return latest version via GitHub', async () => {
     nock('https://api.github.com')
       .get(`/repos/${org}/${repo}/releases/latest`)
       .reply(200, jsonTestGithub);
@@ -48,7 +48,7 @@ describe('getLatestVersion()', () => {
     expect(versionLatest).toMatch(versionLatestExpected);
   });
 
-  test('should return exception 404', async () => {
+  test('return exception 404', async () => {
     nock('https://formulae.brew.sh')
       .get(`/api/formula/${repo}.json`)
       .reply(404);

diff --git a/__tests__/get-os.test.ts b/__tests__/get-os.test.ts
@@ -1,13 +1,13 @@
 import {getOS} from '../src/get-os';
 
 describe('getOS()', () => {
-  test('should return expected OS name', () => {
+  test('return expected OS name', () => {
     expect(getOS('linux')).toBe('unknown-linux-gnu');
     expect(getOS('darwin')).toBe('apple-darwin');
     expect(getOS('win32')).toBe('pc-windows-msvc');
   });
 
-  test('should return exception', () => {
+  test('return exception', () => {
     expect(() => {
       getOS('centos');
     }).toThrowError('centos is not supported');

diff --git a/__tests__/get-url.test.ts b/__tests__/get-url.test.ts
@@ -1,7 +1,7 @@
 import {getURL} from '../src/get-url';
 
 describe('getURL()', () => {
-  test('should return extected URL', () => {
+  test('return extected URL', () => {
     const testVersion: string = '0.3.5';
     const baseURL: string = `https://github.com/rust-lang/mdBook/releases/download/v${testVersion}/mdbook-v${testVersion}-x86_64`;
     const urlLinux: string = `${baseURL}-unknown-linux-gnu.tar.gz`;

diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts
@@ -11,14 +11,14 @@ afterEach(() => {
 });
 
 describe('Integration testing run()', () => {
-  test('should install custom version', async () => {
+  test('succeed in installing a custom version', async () => {
     const testVersion: string = '0.3.4';
     process.env['INPUT_MDBOOK-VERSION'] = testVersion;
     const result: main.actionResult = await main.run();
     expect(result.output).toMatch(`mdbook v${testVersion}`);
   });
 
-  test('should install latest version', async () => {
+  test('succeed in installing the latest version', async () => {
     const testVersion: string = 'latest';
     process.env['INPUT_MDBOOK-VERSION'] = testVersion;
     const result: main.actionResult = await main.run();
@@ -32,13 +32,13 @@ describe('showVersion()', () => {
     output: ''
   };
 
-  test('should return version', async () => {
+  test('return version', async () => {
     result = await main.showVersion('git', ['--version']);
     expect(result.exitcode).toBe(0);
     expect(result.output).toMatch(/git version/);
   });
 
-  test('should return exception', async () => {
+  test('return exception', async () => {
     try {
       result = await main.showVersion('gitgit', ['--version']);
     } catch (e) {