-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changeset and setTag #128
Comments
I need to add custom tags to the changeset, too. |
Yes @sascha-hendel - if you implement the changes in your fork I'll be happy to merge your pull request :-) Nice to see there's still some interest in this package ;-) |
Thanks for the immediate reply! Ok, I will have a deeper look on the code in some weeks and hopefully extend the code to support individual changeset tags. |
Tested my fork with a setTag method for changeset now for a while. Seems to work. |
Closing as pr #214 has addressed this, thanks to @sascha-hendel !! |
Hello,
I started using this library (1.0.0RC2), which is really helpful. I can't figure if there is a way yet to change changeset tags. I tried :
And defined tags are not applied. I also tried
$changeset->add($changeset);
to mimic other objects behaviour, but this causes an infinite loop. I'm not sure if setting custom tags on changesets is not permitted yet by the library, or if I missed how to use it.By reading current code, I understand that most of changeset tags are hard-written in
begin
method. If this is not supported, one simple solution could be to add atags
parameter to this function and append custom tags to existing ones. One more complex solution could be to handle PUT HTTP call on changesets.Best regards.
The text was updated successfully, but these errors were encountered: