Add ssh keys management support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| req := testServer.WaitRequest() | ||
|
|
||
| c.Assert(req.Form["name"], DeepEquals, []string{"A"}) |
There was a problem hiding this comment.
I'm thinking this will fail against master. I've recently moved away from sending form params and instead sending JSON body. The test server doesn't yet decode the JSON response, so you can't currently assert JSON content, but this will likely fail as is.
|
@pearkes I believe it should be working fine against master now. |
|
Hey @pearkes, have you had the chance to check out the modified commit? |
|
@plalloni Sorry for the delay. LGTM, thanks! |
pearkes
added a commit
that referenced
this pull request
Mar 5, 2015
Add ssh keys management support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for creating, removing, reading & renaming ssh keys on DO.