Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong color in pdfs #23

Closed
maximeB opened this issue Nov 30, 2012 · 6 comments
Closed

Wrong color in pdfs #23

maximeB opened this issue Nov 30, 2012 · 6 comments

Comments

@maximeB
Copy link

maximeB commented Nov 30, 2012

Note: I'm not sure whether this issue come from mwlib or mwlib.rl.

If I put tags "font color=red" the text in the wiki is red, BUT in the pdf it appears green !
I also tried other colours :

green appears black
yellow → cyan
blue → blue

Quite odd isn't it ?

Thing funny I noticed: if you put font color=red in the pageheader variable (for instance), it works !
It seems the parser is in cause.

@v0lk3r
Copy link
Contributor

v0lk3r commented Dec 3, 2012

I did some tests and came to the conclusion that the PDF viewer might be the culprit!

On Linux acroread and evince displayed the colors correctly. epdfview on the other hand screwed up and red text was displayed in blue.

What PDF viewer are you using?

I am closing the ticket, reopen if the viewer is not to blame

Edit: Article used for testing: https://de.wikipedia.org/w/index.php?title=Benutzer:Volker.haas/Test&oldid=111234274

@v0lk3r v0lk3r closed this as completed Dec 3, 2012
@maximeB
Copy link
Author

maximeB commented Dec 3, 2012

I don't know how to reopen it.
I tested with both evince and acroread.
I tried your test, it correctly appears red, BUT you used a "span" tag with a "style" statement to set the colour red.
My problem is when I use the font tag which can be use to set a colour without a "style" statement.
I will use the "style" way to set text's colour, but still the bug exists in the code !

@schmir schmir reopened this Dec 3, 2012
@schmir
Copy link
Contributor

schmir commented Dec 3, 2012

please provide a test case (probably best as a user page on wikipedia)

@maximeB
Copy link
Author

maximeB commented Dec 3, 2012

I don't know how to provide it. Just put inside a wiki page:
test
then run mw-render or do it with the collection extension, you will see.

@v0lk3r
Copy link
Contributor

v0lk3r commented Dec 3, 2012

Thanks for this ticket - I finally fixed it and had fun with colors!

Totally unrelated side notes:

  • epdfview seems to have problems displaying colors correctly on my machine. I fixed this with apt-get purge epdfview
  • If I am not mistaken, the font tag has been deprecated since HTML 4.01 - this was 1999! The usage of this tag inflicts major physical pain! Please don't ever use this tag again, people get hurt that way!
  • In the future please provide a link to a minimal example of an article that shows the problem. That way you don't force me to make the example. This is what caused the whole confusion since I refused to make a test case with the font tag. (When I finally did, I even logged out and made an anonymous edit ;)). Test cases can easily be constructed in the wikipedia user space after creating an account. See http://de.wikipedia.org/wiki/Benutzer:Volker.haas/Test

@v0lk3r v0lk3r closed this as completed Dec 3, 2012
@maximeB
Copy link
Author

maximeB commented Dec 3, 2012

I'm sorry but to me putting css into html tag is quite dirty too. The users of my wiki may understand better this way to changing the font (actually it is quite "user friendly").
But I agree with you it would be better if people does not use it at all.
For the test sorry but I don't have an account (yet) on wikipedia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants