Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mwlib should pass cookies for authentication for login-required wikis #60

Open
hexmode opened this issue Aug 16, 2016 · 3 comments
Open

Comments

@hexmode
Copy link

hexmode commented Aug 16, 2016

As per subject. See https://phabricator.wikimedia.org/T142924 and the related code.

That hack wouldn't be necessary if there were a way that mwlib could pass cookies the way that parsoid does.

@ckepper
Copy link
Contributor

ckepper commented Aug 17, 2016

Hi Mark,

this is Christoph from PediaPress. Our team has changed quite a bit and I am not sure if I am able to fix this issue. What should I do?

Christoph

Am 16.08.2016 um 09:26 schrieb Mark A. Hershberger notifications@github.com:

As per subject. See https://phabricator.wikimedia.org/T142924 and the related code.

That hack wouldn't be necessary if there were a way that mwlib could pass cookies the way that parsoid does.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Christoph Kepper

PediaPress GmbH
Moritz-Hilf-Str. 26
65549 Limburg

Phone: +49 (0)6131 3271809
http://pediapress.com

@hexmode
Copy link
Author

hexmode commented Aug 17, 2016

To fix this, you would need the process that MediaWiki talks to to store the cookies that MediaWiki sends so that when mwlib talks to MediaWiki, it can pass them back in.

On the MediaWiki side, MW needs to pass the cookies it gets from the user in its requests to mwlib. An example can be see in VisualEditor's code

@ckepper
Copy link
Contributor

ckepper commented Sep 14, 2016

Sorry for the delay. Can you give an example of a wiki that is affected by this bug? It would be helpful for debugging/testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants